Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci 🤖: pr preview url handling #357

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

ci 🤖: pr preview url handling #357

wants to merge 6 commits into from

Conversation

melMass
Copy link
Member

@melMass melMass commented Nov 7, 2023 •
edited
Loading

🤦

  • try to fix the router
  • use the proper hash for the PR commit in the header (it seems to use a temporary one made for gh pages)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://teia-community.github.io/teia-ui/previews/pr-357/
on branch gh-pages at 2023-11-07 16:20 UTC

melMass
melMass commented Nov 7, 2023
View reviewed changes
src/index.jsx Outdated Show resolved Hide resolved
@melMass melMass force-pushed the fix/pr-preview-base-url branch from ae7f458 to c7a3559 Compare November 7, 2023 15:37
@melMass
ci 🤖: fingers crossed
b18233a 
-
@melMass
fix 🐛: tell the router about base_url
523e36e 
this is set to "/" in prod
@melMass
revert ⏪: uneeded changes
23cf89a 
the export is actually used only inside the context so it's fine
melMass
melMass commented Nov 7, 2023
View reviewed changes
Copy link
Member Author

@melMass melMass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@melMass melMass marked this pull request as draft November 7, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@melMass